[padb] r385 committed - Change the default setting for showing values of locals in stack trace...

padb at googlecode.com padb at googlecode.com
Sun Jan 10 15:10:53 GMT 2010


Revision: 385
Author: apittman
Date: Sun Jan 10 07:09:49 2010
Log: Change the default setting for showing values of locals in stack  
traces.
Change the default to not show values and add an over-ride for
full-report mode to enable this.
Showing variables in this way is really useful and is a big step forward,
it does however greatly increase the output and make it harder to spot
patterns in the stack traces themselves so disable it by default and leave
it up to the user to enable it on a per-run basis if they want.

http://code.google.com/p/padb/source/detail?r=385

Modified:
  /trunk/src/padb

=======================================
--- /trunk/src/padb	Sun Jan 10 07:02:48 2010
+++ /trunk/src/padb	Sun Jan 10 07:09:49 2010
@@ -3109,10 +3109,10 @@
              my $hostp = gdb_read_pointer( $gdb, $struct_base +  
$host_offset );
              my $host = gdb_string( $gdb, 1024, $hostp );

-	    # Ideally this won't happen but it can and does, for example if
-	    # the user supplies a hostsfile with localhost specified the
-	    # resource manager can leave this value unmodified.
-	    if ( defined $host and $host eq 'localhost' ) {
+            # Ideally this won't happen but it can and does, for example if
+            # the user supplies a hostsfile with localhost specified the
+            # resource manager can leave this value unmodified.
+            if ( defined $host and $host eq 'localhost' ) {
                  $host = hostname();
              }

@@ -5339,7 +5339,9 @@
          push_command('deadlock');

          my $c = $conf{mode_options}{stack};
-        $c->{strip_above_wait} = 0;
+        $c->{strip_above_wait}   = 0;
+        $c->{stack_shows_params} = 1;
+        $c->{stack_shows_locals} = 1;
          push_command( 'stack', 'tree', $c );

          go_job($full_report);
@@ -9544,8 +9546,8 @@
              thread_id         => undef,
          },
          options_bool => {
-            stack_shows_params => 'yes',
-            stack_shows_locals => 'yes',
+            stack_shows_params => 'no',
+            stack_shows_locals => 'no',
          },
          secondary => [
              {



More information about the padb-devel mailing list